TYP: check_untyped_defs pandas.core.resample #34692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jun 10, 2020
| @@ -966,7 +966,8 @@ def __init__(self, obj, *args, **kwargs): | |||
| for attr in self._attributes: | |||
| setattr(self, attr, kwargs.get(attr, getattr(parent, attr))) | |||
|
|
|||
| super().__init__(None) | |||
| # error: Too many arguments for "__init__" of "object" | |||
| super().__init__(None) # type: ignore | |||
There was a problem hiding this comment.
If reading the error message correctly can probably just delete this line instead of ignoring
There was a problem hiding this comment.
This is in a mixin, so mypy thinks super() is object.
in use, if the class using the mixin is say DatetimeIndexResamplerGroupby, super() is Resampler where init has the signature is def __init__(self, obj, groupby=None, axis=0, kind=None, **kwargs): and has a required parameter obj, hence the None here.
if we delete this line tests will fail.
========================================================================= short test summary info ==========================================================================
FAILED pandas/tests/resample/test_datetime_index.py::test_resample_apply_with_additional_args - AttributeError: 'DatetimeIndexResamplerGroupby' object has no attribute 'b...
FAILED pandas/tests/resample/test_resampler_grouper.py::test_apply - AttributeError: 'DatetimeIndexResamplerGroupby' object has no attribute 'binner'
============================================== 2 failed, 1670 passed, 10 skipped, 1 xfailed, 2 warnings in 548.51s (0:09:08) ===============================================
| @@ -1569,13 +1570,13 @@ def _get_time_period_bins(self, ax): | |||
| labels = binner = period_range(start=ax[0], end=ax[-1], freq=freq, name=ax.name) | |||
|
|
|||
| end_stamps = (labels + freq).asfreq(freq, "s").to_timestamp() | |||
| if ax.tzinfo: | |||
| end_stamps = end_stamps.tz_localize(ax.tzinfo) | |||
| if ax.tz: | |||
There was a problem hiding this comment.
whats the question? these should be equivalent
|
@WillAyd anything more to do here? |
WillAyd
approved these changes
Jun 13, 2020
|
Thanks @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas\core\resample.py:969: error: Too many arguments for "init" of "object"
pandas\core\resample.py:1572: error: "DatetimeIndex" has no attribute "tzinfo"
pandas\core\resample.py:1573: error: "DatetimeIndex" has no attribute "tzinfo"
pandas\core\resample.py:1585: error: "PeriodIndex" has no attribute "asfreq"; maybe "freq"?
pandas\core\resample.py:1867: error: "PeriodIndex" has no attribute "asfreq"; maybe "freq"?
pandas\core\resample.py:1902: error: "PeriodIndex" has no attribute "asfreq"; maybe "freq"?